Fix bug in the printing of double for limit values #4498
Conversation
romainbrenguier
requested review from
cesaro,
cristina-david,
NathanJPhillips,
peterschrammel,
pkesseli,
smowton and
thk123
as code owners
romainbrenguier
changed the title
| CORE | ||
| double1.class | ||
| --function double1.testLimit --trace | ||
| ^EXIT=0$ |
There was a problem hiding this comment.
I think this should be EXIT=10
| -- | ||
| ^warning: ignoring | ||
| -- | ||
| Test double value are printed with sufficient precision |
There was a problem hiding this comment.
GitHub would like to have a newline here.
romainbrenguier
force-pushed
the
bugfix/double-printing
branch
from
c6aef5b to
f8ef55a
Compare
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: f8ef55a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/107499837
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
The case of numeric limit for floating point does not imply that the decimal version is precise enough. An example of that is 0x1p-1022 which would be printed as 2.22507e-308 in decimal but this is not precise enough.
romainbrenguier
force-pushed
the
bugfix/double-printing
branch
from
f8ef55a to
f992352
Compare
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: f992352).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/107534355
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
romainbrenguier
force-pushed
the
bugfix/double-printing
branch
from
f992352 to
b453805
Compare
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: b453805).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/107581083
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
romainbrenguier
force-pushed
the
bugfix/double-printing
branch
2 times, most recently
from
09801c3 to
9acc299
Compare
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 09801c3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/107586414
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
This checks a limit double value is printed with sufficient precision (the decimal version would not work so we have to use the hexidecimal).
romainbrenguier
force-pushed
the
bugfix/double-printing
branch
from
9acc299 to
edfccab
Compare
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 9acc299).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/107590471
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: edfccab).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/107595723
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
This corrects a bug in which the minimal value for a double was not printed precisely enough.